[pnfs] pnfs 2.6.18 bakeathon patches

[Rahul Iyer]

William A. (Andy) Adamson wrote:
> 
> 
> On 10/17/07, *dean hildebrand* <seattleplus at gmail.com 
> <mailto:seattleplus at gmail.com>> wrote:
> 
>     I looked into a little and you are right Rahul, the client side
>     maximum number of slots follows sunrpc.tcp_slot_table_entries.
> 
>     One interesting note is that on the server in alloc_init_session, the
>     following code restricts the value:
> 
>             if (cses->fore_channel.maxreqs >= NFS41_MAX_SLOTS)
>                     cses->fore_channel.maxreqs = NFS41_MAX_SLOTS;
> 
>     where
> 
>     #define NFS41_MAX_SLOTS                64
> 
> 
> the patch that bumps the define to 64 is no good - we want to use 128.  
> shouldn't the above check use sunrpc.tcp_slot_table_entries instead of 
> NFS41_MAX_SLOTS? then we can leave NFS41_MAX_SLOTS at 16.
>

Yes. I agree. Using #defines instead of variables is problematic because 
it makes it hard to change from a /proc interface, if we ever need to.
-Rahul