[pnfs] question about getdevlist server code

Sager, Mike Mike.Sager at netapp.com
Wed Oct 31 17:33:37 EDT 2007


Hi,

I have a question about a recent patch to the 2.6.23-based server.  When
the server is encoding the response to GETDEVLIST in
nfsd4_encode_getdevlist(), it's doing:

        if (!nfserr) {
                RESERVE_SPACE(20 + sizeof(nfs4_verifier));
                WRITE64(gdevl->gd_cookie);
                WRITEMEM(&gdevl->gd_verf, sizeof(nfs4_verifier));

                // num of devlist_item4
                WRITE32(1);

                WRITE32(gdevl->gd_devlist[0].dev_id);

                ADJUST_ARGS();
                len = nfsd4_encode_devlist_item(resp, gdevl);

                RESERVE_SPACE(4);
                WRITE32(gdevl->gd_eof);
                ADJUST_ARGS();
                kfree(gdevl->gd_devlist);
        }


It seems to be hardcoding the number of devices to 1.  I'm told there
was some discussion at Bakeathon about this.  Can someone shed some
light on why it's doing this?

Thanks,
Mike


More information about the pNFS mailing list