[pnfs] question about getdevlist server code

[dean hildebrand]

The goal was to just get the server working with draft-13.

The other reason we didn't spend too much time solving it for the
generic case was that we decided on a new export interface for
devices.    It seems there was agreement on this new interface last
week and I'm going to start implementing it as soon as I get a chance.
 Right now I'm swamped preparing for supercomputing, but I will send
out a patch in the next couple of weeks.

Dean

On Oct 31, 2007 2:33 PM, Sager, Mike <Mike.Sager at netapp.com> wrote:
> Hi,
>
> I have a question about a recent patch to the 2.6.23-based server.  When
> the server is encoding the response to GETDEVLIST in
> nfsd4_encode_getdevlist(), it's doing:
>
>        if (!nfserr) {
>                RESERVE_SPACE(20 + sizeof(nfs4_verifier));
>                WRITE64(gdevl->gd_cookie);
>                WRITEMEM(&gdevl->gd_verf, sizeof(nfs4_verifier));
>
>                // num of devlist_item4
>                WRITE32(1);
>
>                WRITE32(gdevl->gd_devlist[0].dev_id);
>
>                ADJUST_ARGS();
>                len = nfsd4_encode_devlist_item(resp, gdevl);
>
>                RESERVE_SPACE(4);
>                WRITE32(gdevl->gd_eof);
>                ADJUST_ARGS();
>                kfree(gdevl->gd_devlist);
>        }
>
>
> It seems to be hardcoding the number of devices to 1.  I'm told there
> was some discussion at Bakeathon about this.  Can someone shed some
> light on why it's doing this?
>
> Thanks,
> Mike
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>