[pnfs] Fwd: Re: [PATCH 0/4] deviceid64: change deviceid u64

Benny Halevy bhalevy at panasas.com
Tue Sep 4 14:42:31 EDT 2007


Forwarding reply from Spencer.

Benny

On Sep 04, 2007, at 20:42 +0300, Spencer Shepler <Spencer.Shepler at Sun.COM> wrote:
> It appears to be a typo when changing the way the draft is generated.
> 
> I will change it in draft-14.

On Aug 27, 2007, at 9:48 +0300, Benny Halevy <bhalevy at panasas.com> wrote:
> This is odd. deviceid4 was uint64 in draft-12 and was resized back to uint32
> in draft13. Spencer, any clue why?
> 
> Benny
> 
> Marc Eshel wrote:
>> It looks like this change to 64bit deviceid did not make draft 13 so 
>> lets wait with this changes.
>> Marc.
>>
>> Benny Halevy wrote:
>>
>>> Marc noticed that I forgot to reserve space for the 64 bit deviceid
>>> in several places.  Version 2 of the four patches sent.  Thanks Marc!
>>>
>>> Benny
>>>
>>> Benny Halevy wrote:
>>>  
>>>
>>>> As of draft-ietf-nfsv4-minorversion1-12.txt deviceid4 is defined as
>>>> typedef uint64_t deviceid4;
>>>>
>>>> This patchset against the master linux-pnfs branch includes:
>>>> [PATCH 1/4] deviceid64: nfs client
>>>> [PATCH 2/4] deviceid64: filelayout client
>>>> [PATCH 3/4] deviceid64: nfs server
>>>> [PATCH 4/4] deviceid64: filelayout server
>>>>
>>>> $ git-diff --stat 7d4936c8a5b4d5846a56f1b60b1f99dbbc89e051
>>>> fs/nfs/nfs4filelayout.c            |   16 ++++++++--------
>>>> fs/nfs/nfs4filelayout.h            |    8 ++++----
>>>> fs/nfs/nfs4filelayoutdev.c         |   35 +++++++++++++++++++++++------------
>>>> fs/nfs/nfs4proc.c                  |    6 +++---
>>>> fs/nfs/nfs4xdr.c                   |    8 ++++----
>>>> fs/nfs/pnfs.c                      |    4 ++--
>>>> fs/nfsd/nfs4filelayoutxdr.c        |    2 +-
>>>> fs/nfsd/nfs4proc.c                 |    4 ++--
>>>> fs/nfsd/nfs4state.c                |    2 +-
>>>> fs/nfsd/nfs4xdr.c                  |    4 ++--
>>>> include/linux/nfs4_pnfs.h          |   14 ++++++++------
>>>> include/linux/nfs_page.h           |    3 ++-
>>>> include/linux/nfsd/nfs4layoutxdr.h |    2 +-
>>>> include/linux/nfsd/nfsd4_pnfs.h    |    4 ++--
>>>> include/linux/nfsd/pnfsd.h         |    2 +-
>>>> include/linux/nfsd/state.h         |    2 +-
>>>> include/linux/pnfs_xdr.h           |    2 +-
>>>> 17 files changed, 66 insertions(+), 52 deletions(-)
>>>>    
>>>>
>>>  
>>>
> 
> 



More information about the pNFS mailing list