[pnfs] Oops in latest pnfs client

[Halevy, Benny]

ACK.
Sorry for not testing this change without pnfs.
 
Benny


________________________________

	From: pnfs-bounces at linux-nfs.org
[mailto:pnfs-bounces at linux-nfs.org] On Behalf Of Sager, Mike
	Sent: Thursday, September 06, 2007 12:32 PM
	To: pnfs at linux-nfs.org
	Subject: [pnfs] Oops in latest pnfs client
	
	
	Using the latest 2.6.18 pnfs client, I'm hitting an Oops when
executing basic test #1 of  connectathon -- in particular, when it's
trying to remove a test directory.
	 
	The key is that I'm running 4.1 in a non-pnfs environment, i.e.,
no data servers.  The Oops occurs near the beginning of
pnfs_return_layout (as a sidenote, should this be getting called if
there's no layout?) at:
	 
	       arg.layout_type = server->pnfs_curr_ld->id;
	 
	It's a null dereference as pnfs_curr_ld is 0.
	 
	Prior to recent updates, it didn't get that far due to this
check right before:
	 
	        if (nfsi->current_layout == NULL)
	                return 0;
	 
	I'll submit a patch to restore the check unless there's some
objection (I verified that cthon basic/general/special pass with it).
	 
	Mike
	 
	 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://linux-nfs.org/pipermail/pnfs/attachments/20070906/ee933886/attachment-0001.htm