[pnfs] [PATCH] pnfs: do proc_commit_setup unconditionally
Benny Halevy
bhalevy at panasas.com
Thu Sep 20 17:20:37 EDT 2007
pnfs_use_nfsv4_wproto is unrelated to preparing the commit rpc
as it is called from nfs_commit_rpcsetup also when the writes
were performed to the MDS.
related TODO: we need to identify per-page whether it needs commit via
the MDS or via the layout driver. If it was written asynchronously
via the layout driver it MUST be commited on the DS (or whatever
storage device is used) if this fails, falling back to committing
via the MDS is not guranteed to commit on the DS hence
EIO should be returned to the app.
Signed-off-by: Benny Halevy <bhalevy at panasas.com>
---
fs/nfs/nfs4proc.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index b76d435..87786ac 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3855,9 +3855,6 @@ static void pnfs4_proc_commit_setup(struct nfs_write_data *data, int how)
int flags;
- if (!pnfs_use_nfsv4_wproto(data->inode, -1))
- return;
-
/* Set up the initial task struct. */
flags = (how & FLUSH_SYNC) ? 0 : RPC_TASK_ASYNC;
--
1.5.3.1
More information about the pNFS
mailing list