[pnfs] white spaces in linux-pnfs-2.6-latest.git

Benny Halevy bhalevy at panasas.com
Thu Sep 20 17:09:50 EDT 2007


Ricardo,

I tried applying some patches I prepared for the 2.6.18.3 tree
onto your 2.6.23-rc6 tree and it looks like they differ in white space
(e.g. fs/nfsd/nfs4state.c)

When we started working on 2.6.18 we decided we will use the current
linux kernel coding style for new code and therefore the patches
we made use tab characters for indentation. That said, we also decided
to defer cleaning up white spaces in existing code in a minimalistic
approach.

Did you guys convert tab indents to spaces when you pulled
over the patches from the 2.6.18.3 tree?
If so, it seems like a step back in the wrong direction
and makes patching both trees concurrently harder...

Trond/Bruce/Andy: is there still a plan to clean up the existing
code base, at least with respect to tab indentation?

Benny


More information about the pNFS mailing list