[pnfs] white spaces in linux-pnfs-2.6-latest.git

Trond Myklebust Trond.Myklebust at netapp.com
Fri Sep 21 10:16:14 EDT 2007


On Fri, 2007-09-21 at 09:00 -0400, J. Bruce Fields wrote:
> On Fri, Sep 21, 2007 at 08:50:30AM -0400, Trond Myklebust wrote:
> >  Patches with large amounts of whitespace errors (large == so many that
> > they cannot be fixed up by me by hand) will be rejected. I'm not going
> > to accept a solution that first introduces errors, then removes them.
> > The main reason is that utilities like 'lindent' tend to do a lot of
> > other useless and screwed up reformatting that needs to be cleaned up
> > afterwards too.
> 
> The existing patches are going to need lots of reworking anyway to meet
> the requirement that individual patches don't introduce new bugs.  (So
> for example any commit that fixes a bug from an earlier pNFS work is
> eventually going to have to be reordered and folded into the change that
> introduced the bug.)
> 
> So as long as someone's doing that sort of thing, I don't think it'll be
> that much more trouble just to run through the patches and fix up
> any whitespace problems they introduce.

In fact, making a little perl or sed script that directly transforms the
patches themselves should be a 5 minute task.

  Trond


More information about the pNFS mailing list