[pnfs] [PATCH 11/11] pnfs: COMMENT: pnfs4_read_done

[Benny Halevy]

On Apr. 10, 2008, 17:05 +0300, Fred Isaman <iisaman at citi.umich.edu> wrote:
> Signed-off-by: Fred Isaman <iisaman at citi.umich.edu>
> ---
>  fs/nfs/nfs4proc.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 85f364b..3a54c7e 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3008,6 +3008,10 @@ static int pnfs4_read_done(struct rpc_task *task, struct nfs_read_data *data)
>  		return -EAGAIN;
>  	}
>  
> +	/* FRED - why is this the only .read_done that does not call
> +	 * nfs_invalidate_atime?
> +	 */

Why don't we figure that out on the mailing list rather
than adding a comment that will more likely to just get lost? :)

Benny

> +
>  	/* Only renew lease if this was a read call to MDS */
>  	if (task->tk_status > 0 && !data->ds_nfs_client)
>  		renew_lease(mds_svr, data->timestamp);