[pnfs] [PATCH 11/11] pnfs: COMMENT: pnfs4_read_done

[Dean Hildebrand]

Fredric Isaman wrote:
> On Sun, 13 Apr 2008, Benny Halevy wrote:
>
>   
>> On Apr. 10, 2008, 17:05 +0300, Fred Isaman <iisaman at citi.umich.edu> wrote:
>>     
>>> Signed-off-by: Fred Isaman <iisaman at citi.umich.edu>
>>> ---
>>>  fs/nfs/nfs4proc.c |    4 ++++
>>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
>>> index 85f364b..3a54c7e 100644
>>> --- a/fs/nfs/nfs4proc.c
>>> +++ b/fs/nfs/nfs4proc.c
>>> @@ -3008,6 +3008,10 @@ static int pnfs4_read_done(struct rpc_task *task, struct nfs_read_data *data)
>>>  		return -EAGAIN;
>>>  	}
>>>
>>> +	/* FRED - why is this the only .read_done that does not call
>>> +	 * nfs_invalidate_atime?
>>> +	 */
>>>       
>> Why don't we figure that out on the mailing list rather
>> than adding a comment that will more likely to just get lost? :)
>>
>> Benny
>>
>>     
>
> OK. So...does anyone know why?
>   
It looks like Trond added it btw 2.6 23 and 2.6.25.  I'm assuming we 
should add it since pnfs4_read_done is supposed to just be a copy of 
nfs4_read_done with our pnfs changes.
Dean
>  	Fred
>
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>