[pnfs] [PATCH 01/11] pnfs: fix pnfs_v41_clientops

[Benny Halevy]

On Apr. 14, 2008, 16:19 +0300, Fredric Isaman <iisaman at citi.umich.edu> wrote:
> 
> On Fri, 11 Apr 2008, Dean Hildebrand wrote:
> 
>>
>> Fred Isaman wrote:
>>> The change to file_ops is needed to ensure that a layout is asked
>>> for early in the write, before it is chopped into page-sized chunks.
>>>
>>> I'm not sure what is going on here, pnfs_*_operations are set in
>>> nfs_v40_clientops but not in either nfs_v41_clientops or
>>> pnfs_v41_clientops.  Further, it seems somewhat intentional, given
>>> the comment in commit 1c7bac9f89b47a...
>>>
>> there is definitely a problem here.  The nfs_v40_clientops has
>> .file_ops       = &pnfs_file_operations,
>> .setattr        = pnfs4_proc_setattr,
>>
>> etc.  this is definitely wrong. 
>> would you mind fixing up this patch to restore the nfs_v40_client ops to the 
>> correct versions.

I fixed that in my local tree along with rebasing to 2.6.25-rc9.
Will release soon.

Benny

>>
>> Dean
> 
> OK.
> 
> Fred
> 
>>> Signed-off-by: Fred Isaman <iisaman at citi.umich.edu>
>>> ---
>>>  fs/nfs/nfs4proc.c |    4 ++--
>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
>>> index c26b2ac..85f364b 100644
>>> --- a/fs/nfs/nfs4proc.c
>>> +++ b/fs/nfs/nfs4proc.c
>>> @@ -5577,10 +5577,10 @@ const struct nfs_rpc_ops pnfs_v41_clientops = {
>>>  	.dentry_ops	= &nfs4_dentry_operations,
>>>  	.dir_inode_ops	= &nfs4_dir_inode_operations,
>>>  	.file_inode_ops	= &nfs4_file_inode_operations,
>>> -	.file_ops	= &nfs_file_operations,
>>> +	.file_ops	= &pnfs_file_operations,
>>>  	.getroot	= nfs4_proc_get_root,
>>>  	.getattr	= nfs4_proc_getattr,
>>> -	.setattr	= nfs4_proc_setattr,
>>> +	.setattr	= pnfs4_proc_setattr,
>>>  	.lookupfh	= nfs4_proc_lookupfh,
>>>  	.lookup		= nfs4_proc_lookup,
>>>  	.access		= nfs4_proc_access,
>>>
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs