[pnfs] Remaining non-callback TODO's from the 11-13-08 code review

William A. (Andy) Adamson androsadamson at gmail.com
Thu Dec 18 16:17:50 EST 2008


As far as I can tell, these are the comments that still need to be
addressed. Mike Sager and I are doing some of them, the others are up
for grabs!

The patch number matches the origional list in the [PATCH 0/50]
message i just sent.

-->Andy



0023-nfsd41-xdr-stubs.patch
        TODO comment:
        review 11-13: add comment about why we don't need nfsd4_enc_ops
        per minorversion like we do for the decoding vector.

0025-nfsd41-exchange_id-operation.patch
Mike Sager
        TODO comments:
        review 11-13: Andy to add a "TODO" comment.
        Document the ramfications of the present implementation
        shortcuts we made.
        Document server owner implementation.

Mike Sager
        nfsd4_encode_exchange_id()
        review 11-13: use utsname for major_id (and copy to server_scope)
        MUST DO before submitting.

0033-nfsd41-DRC-save-restore-and-clear-functions.patch
Andy Adamson
       TODO for future DRC patches:
        nfsd41_replay_cache_entry()
        review 11-13: no spin lock, yes state lock
        do this call in nfsd4_sequence under the state lock.
        do nothing in nfs4svc_encode_compoundres

0027-nfsd41-create_session-operation.patcho

Andy Adamson
       TODO: set correct limits on session parameters.
        review 11-13: this is being rewritten by Andy.

0030-nfsd41-destroy_session-operation.patch

        TODO comments:
        > +     shutdown_callback_client(ses->se_client);

        review 11-12: we need ref. counting for that backchannel
        to support trunking.
        clp->cl_callback.cb_client is shared?


More information about the pNFS mailing list