[pnfs] [PATCH 1/1] pnfsd: filelayout_encode_layout should return pos err codes
J. Bruce Fields
bfields at fieldses.org
Fri Feb 1 15:07:55 EST 2008
On Wed, Jan 30, 2008 at 10:40:51AM -0800, Dean Hildebrand wrote:
> You are looking at the wrong repository. This builds on
> filelayout-draft-13. The code below is totally rewritten.
>
> My thinking is that since filelayout_encode_layout is now called from
> the underlying file system, it should return positive error codes. Once
> it returns to nfsd, it should negate the error codes from any sub calls.
Nothing in the kernel should use a positive error code without an
extremely good reason. The convention of returning -ERRNO is so
pervasive that anything else will just confuse people.
--b.
More information about the pNFS
mailing list