[pnfs] [PATCH 2/5] pnfs: remove redundant ifdef

Benny Halevy bhalevy at panasas.com
Sun Feb 3 04:39:23 EST 2008


Actually, instead of removing the redundant ifdef
we can apply it onto nfs4_fsinfo_bitmap (in a non-redundant way :)
and get rid of the pnfs-specific fsinfo encoding path.
(nfs4_xdr_enc_pnfs_fsinfo -> encode_pnfs_fsinfo)

Benny

andros at umich.edu wrote:
> From: Fred Isaman <iisaman at citi.umich.edu>
> 
> Remove an ifdef/else/endif series which is located inside an ifdef.
> 
> Signed-off-by: Fred Isaman <iisaman at citi.umich.edu>
> ---
>  fs/nfs/nfs4proc.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 1f94bf5..abf26f9 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -130,11 +130,7 @@ const u32 nfs4_pnfs_fsinfo_bitmap[2] = { FATTR4_WORD0_MAXFILESIZE
>  			| FATTR4_WORD0_MAXREAD
>  			| FATTR4_WORD0_MAXWRITE
>  			| FATTR4_WORD0_LEASE_TIME,
> -#ifdef CONFIG_PNFS
>  			FATTR4_WORD1_FS_LAYOUT_TYPES
> -#else /* CONFIG_PNFS */
> -			0
> -#endif /* CONFIG_PNFS */
>  };
>  #endif /* CONFIG_PNFS */
>  



More information about the pNFS mailing list