[pnfs] [PATCH 05/25] pnfs: block: STUB: NFS4_PNFS_DEV_MAXSIZE too small

[Benny Halevy]

On Feb. 14, 2008, 20:21 +0200, Fred Isaman <iisaman at citi.umich.edu> wrote:
> This patch doesn't do anything.  It is just a reminder that
> NFS4_PNFS_DEV_MAXSIZE is way too small, and needs to be
> changed from static to dynamic allocation.
> 
> Signed-off-by: Fred Isaman <iisaman at citi.umich.edu>
> ---
>  include/linux/nfs4_pnfs.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/nfs4_pnfs.h b/include/linux/nfs4_pnfs.h
> index 655f1f7..dee278a 100644
> --- a/include/linux/nfs4_pnfs.h
> +++ b/include/linux/nfs4_pnfs.h
> @@ -17,6 +17,7 @@
>  #include <linux/nfs_page.h>
>  
>  #define NFS4_PNFS_DEV_MAXNUM 16
> +/* This is way too small for block driver */

This warrants a "FIXME: " prefix in the comment.

Benny

>  #define NFS4_PNFS_DEV_MAXSIZE 128
>  
>  /* Per-layout driver specific registration structure */