[pnfs] [PATCH 05/10] nfs41: NFSv4.1 callback structures

Benny Halevy bhalevy at panasas.com
Thu Jan 3 08:27:20 EST 2008


On Jan. 03, 2008, 2:01 +0200, Ricardo Labiaga <ricardo.labiaga at netapp.com> wrote:
<snip>
> diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h
> index b64d8df..6777793 100644
> --- a/include/linux/sunrpc/xprt.h
> +++ b/include/linux/sunrpc/xprt.h
> @@ -170,7 +170,12 @@ struct rpc_xprt {
>  	struct rpc_task *	snd_task;	/* Task blocked in send */
>  #if defined(CONFIG_NFSD_V4_1)
>  	struct svc_sock	       *svsk;           /* If this is a callback xprt */
> -#endif
> +#endif /* CONFIG_NFSD_V4_1 */
> +#if defined(CONFIG_NFS_V4_1)
> +	struct svc_serv		*serv;		/* The RPC service which will process the callback request */

Can you please break/shorten this comment to keep the line shorter than 80 chars?

> +	unsigned long		bc_flags;	/* Backchannel flags */
> +	struct rpc_rqst		*bc_rpc_rqst;	/* Preallocated backchannel rpc_rqst */

ditto

> +#endif /* CONFIG_NFS_V4_1 */
>  	struct list_head	recv;
>  
>  	struct {
> @@ -189,6 +194,13 @@ struct rpc_xprt {
>  	char *			address_strings[RPC_DISPLAY_MAX];
>  };
>  
> +#if defined(CONFIG_NFS_V4_1)
> +/*
> + * Backchannel flags
> + */
> +#define	RPC_BC_PREALLOC_IN_USE	0x0001	/* Preallocated backchannel buffers in use */

ditto

> +#endif /* CONFIG_NFS_V4_1 */
> +
>  struct xprt_create {
>  	int			ident;		/* XPRT_TRANSPORT identifier */
>  	struct sockaddr *	srcaddr;	/* optional local address */

Thanks
- Benny


More information about the pNFS mailing list