[pnfs] [PATCH 01/10] nfs41: Add ability to read RPC call direction on TCP stream.

[Ricardo Labiaga]

Agreed.

- ricardo

On Thu, 2008-01-03 at 15:17 +0200, Benny Halevy wrote:
> Ricardo, I have some pesty style related comments below (and in other patches)
> You seem to be working on Bruce's comments to patch #5 so
> I'd appreciate if you could fixed the minor style issues as well.
> 
> Thanks,
> 
> Benny
> 
> On Jan. 03, 2008, 2:01 +0200, Ricardo Labiaga <ricardo.labiaga at netapp.com> wrote:
> <snip>
> > @@ -265,6 +266,7 @@ struct sock_xprt {
> >  #define TCP_RCV_COPY_FRAGHDR	(1UL << 1)
> >  #define TCP_RCV_COPY_XID	(1UL << 2)
> >  #define TCP_RCV_COPY_DATA	(1UL << 3)
> > +#define	TCP_RCV_COPY_CALLDIR	(1UL << 4)
> 
> please use same indentation convention as existing code above,
> i.e. space after #define rather than tab so the added line doesn't stick out.
> 
> <snip>  
> > +static inline void xs_tcp_read_calldir(struct sock_xprt *transport, struct xdr_skb_reader *desc)
> 
> I know that existing function definitions in this file are declared on
> infinitely long lines but let's try stick to the existing coding style
> where it makes sense so this one better be broken like this:
> 
> static inline void xs_tcp_read_calldir(struct sock_xprt *transport,
> 				       struct xdr_skb_reader *desc)
> 
> Thanks,
> 
> Benny