[pnfs] [PATCH 02/10] nfs41: Refactor NFSv4 callback service

[Ricardo Labiaga]

Agreed.

- ricardo

On Thu, 2008-01-03 at 15:22 +0200, Benny Halevy wrote:
> More pesty comment below :)
> 
> On Jan. 03, 2008, 2:01 +0200, Ricardo Labiaga <ricardo.labiaga at netapp.com> wrote:
> <snip>
> 
> > +/*
> > + * Bring up the NFSv4 callback service
> > + */
> > +int nfs4_callback_up(struct svc_serv *serv)
> > +{
> > +	int ret = 0;
> > +
> > +	ret = svc_makesock(serv, IPPROTO_TCP, nfs_callback_set_tcpport,
> > +							SVC_SOCK_ANONYMOUS);
> > +	if (ret < 0)
> > +		return ret;
> > +	nfs_callback_tcpport = ret;
> > +	dprintk("Callback port = 0x%x\n", nfs_callback_tcpport);
> > +	ret = svc_create_thread(nfs4_callback_svc, serv);
> > +
> > +	return ret;
> 
> Why assign again to ret?
> you can just do "return svc_create_thread(nfs4_callback_svc, serv);"
> and save a couple unneeded lines
> 
> Benny
> 
> > +}