[pnfs] [PATCH 03/13] pnfsd: Simplify getdeviceinfo export ops.

[Dean Hildebrand]

Benny Halevy wrote:
> Dean, this patch would break compilation of the tree
> so it makes the patchset non-bisectable.  The main problem
> with that is if a regression is found we can't use git-bisect
> to semi-automatically find the offending patch in O(log(#patches)).
>   
I agree, but I'm not sure how.  That patch changes a data structure that 
is used in a lot of different places.  Should I merge all patches 
together that are affected by the change to this data structure? (I 
think that is almost all of my patches)
Dean
> Also, minor nit below.
>
> Thanks for sending the patches!
>
> Benny
>
> On Jan. 10, 2008, 23:38 +0200, seattleplus at gmail.com wrote:
> <snip>
>
>   
>> @@ -35,6 +35,35 @@ enum fid_type {
>>  	FILEID_INO32_GEN_PARENT = 2,
>>  };
>>  
>> +#if defined(CONFIG_PNFS)
>> +
>> +/* XDR stream arguments and results.  Exported file system uses this
>> + * struct to encode information and return how many bytes were encoded.
>> + */
>> +struct pnfs_xdr_info {
>> +	u32 *p;			/* in */
>> +	u32 *end;		/* in */
>> +	u32 maxcount;		/* in */
>> +	u32 bytes_written;	/* out */
>> +};
>> +
>> +/* Used by get_device_info to encode a device (da_addr_body in spec)
>> + * Args:
>> + * xdr - xdr stream
>> + * device - pointer to device to be encoded
>> +*/
>> +typedef int (*pnfs_encodedev_t)(struct pnfs_xdr_info *xdr, void *device);
>> +
>> +/* Arguments for get_device_info */
>> +struct pnfs_devinfo_arg {
>> +	u32 type;
>> +	u32 devid;
>> +	struct pnfs_xdr_info xdr;
>> +	pnfs_encodedev_t func;
>> +};
>> +
>> +#endif
>>     
>
> please add comment after #endif, like this:
> #endif /* CONFIG_PNFS */
>
>
>