[pnfs] 2.6.26 kernel hacking built option heads-up

[William A. (Andy) Adamson]

On Wed, Jul 23, 2008 at 3:26 PM, J. Bruce Fields <bfields at fieldses.org> wrote:
> On Wed, Jul 23, 2008 at 03:14:23PM -0400, Andy Adamson wrote:
>> The lib/list_debug.c code that replaces the include/linux/list.h list
>> manipulation functions when the kernel hacking list debugging is turned
>> on is NOT SMP safe - no smp_wmb calls....
>
> More importantly, there's never been any protection of the list
> manipulations themselves--locking is up to the caller.  So unless I'm
> missing something subtle, I don't think the debugging code changes
> anything.

maybe you're right - on second look, i was comparing apples and
oranges - __list_add_rcu in list.h and __list_add in list_debug.c.
i'll turn list debugging back on.


-->Andy

>
> --b.
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>
>