[pnfs] [PATCH 10/17] [SQUASHME] nfs41: remove commented code in nfs4_async_handle_error

Benny Halevy bhalevy at panasas.com
Tue Jun 3 13:40:06 EDT 2008


Calling nfs41_recover_session_async from nfs4_async_handle_error
was never functional.  marking the session as expired and letting
the validate_args method recover the session is doing this correctly.

Signed-off-by: Benny Halevy <bhalevy at panasas.com>
---
 fs/nfs/nfs4proc.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index afd25a6..3237b45 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3317,11 +3317,6 @@ nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server,
 		case -NFS4ERR_RETRY_UNCACHED_REP:
 		case -NFS4ERR_TOO_MANY_OPS:
 		case -NFS4ERR_OP_NOT_IN_SESSION:
-			/* FIXME:
-			ret = nfs41_recover_session_async(task, server);
-			if (ret)
-				return ret;
-			*/
 			nfs41_set_session_expired(server->session);
 			task->tk_status = 0;
 			return -EAGAIN;
-- 
1.5.3.3



More information about the pNFS mailing list