[pnfs] wireshark

[J. Bruce Fields]

See comments at end.

On Mon, May 26, 2008 at 09:13:20AM +0200, Tigran Mkrtchyan wrote:
> Subject: [PATCH 08/12] complete list of nfsv4.1 ops
> 
> ---
>  epan/dissectors/packet-nfs.c |   83 ++++++++++++++++++++++++------------------
>  1 files changed, 47 insertions(+), 36 deletions(-)
> 
> diff --git a/epan/dissectors/packet-nfs.c b/epan/dissectors/packet-nfs.c
> index ea4a446..80657fe 100644
> --- a/epan/dissectors/packet-nfs.c
> +++ b/epan/dissectors/packet-nfs.c
> @@ -7101,56 +7101,67 @@ dissect_nfs_stable_how4(tvbuff_t *tvb, int offset,
>  
>  static const value_string names_nfsv4_operation[] = {
>  	{	NFS4_OP_ACCESS,					"ACCESS"	},
> -	{	NFS4_OP_CLOSE,						"CLOSE"	},
> +	{	NFS4_OP_CLOSE,					"CLOSE"	},
>  	{	NFS4_OP_COMMIT,					"COMMIT"	},
>  	{	NFS4_OP_CREATE,					"CREATE"	},
>  	{	NFS4_OP_DELEGPURGE,				"DELEGPURGE"	},
> -	{	NFS4_OP_DELEGRETURN,				"DELEGRETURN"	},
> -	{	NFS4_OP_GETATTR,					"GETATTR"	},
> -	{	NFS4_OP_GETFH,						"GETFH"	},
> -	{	NFS4_OP_LINK,						"LINK"	},
> -	{	NFS4_OP_LOCK,						"LOCK"	},
> -	{	NFS4_OP_LOCKT,						"LOCKT"	},
> -	{	NFS4_OP_LOCKU,						"LOCKU"	},
> +	{	NFS4_OP_DELEGRETURN,			"DELEGRETURN"	},
> +	{	NFS4_OP_GETATTR,				"GETATTR"	},
> +	{	NFS4_OP_GETFH,					"GETFH"	},
> +	{	NFS4_OP_LINK,					"LINK"	},
> +	{	NFS4_OP_LOCK,					"LOCK"	},
> +	{	NFS4_OP_LOCKT,					"LOCKT"	},
> +	{	NFS4_OP_LOCKU,					"LOCKU"	},
>  	{	NFS4_OP_LOOKUP,					"LOOKUP"	},
> -	{	NFS4_OP_LOOKUPP,					"LOOKUPP" },
> -	{	NFS4_OP_NVERIFY,					"NVERIFY"	},
> -	{	NFS4_OP_OPEN,						"OPEN"	},
> -	{	NFS4_OP_OPENATTR,					"OPENATTR"	},
> +	{	NFS4_OP_LOOKUPP,				"LOOKUPP" },
> +	{	NFS4_OP_NVERIFY,				"NVERIFY"	},
> +	{	NFS4_OP_OPEN,					"OPEN"	},
> +	{	NFS4_OP_OPENATTR,				"OPENATTR"	},
>  	{	NFS4_OP_OPEN_CONFIRM,			"OPEN_CONFIRM"	},
>  	{	NFS4_OP_OPEN_DOWNGRADE,			"OPEN_DOWNGRADE"	},
> -	{	NFS4_OP_PUTFH,						"PUTFH"	},
> -	{	NFS4_OP_PUTPUBFH,					"PUTPUBFH"	},
> +	{	NFS4_OP_PUTFH,					"PUTFH"	},
> +	{	NFS4_OP_PUTPUBFH,				"PUTPUBFH"	},
>  	{	NFS4_OP_PUTROOTFH,				"PUTROOTFH"	},
> -	{	NFS4_OP_READ,						"READ"	},
> -	{	NFS4_OP_READDIR,					"READDIR"	},
> -	{	NFS4_OP_READLINK,					"READLINK"	},
> +	{	NFS4_OP_READ,					"READ"	},
> +	{	NFS4_OP_READDIR,				"READDIR"	},
> +	{	NFS4_OP_READLINK,				"READLINK"	},
>  	{	NFS4_OP_REMOVE,					"REMOVE"	},
>  	{	NFS4_OP_RENAME,					"RENAME"	},
> -	{	NFS4_OP_RENEW,						"RENEW"	},
> +	{	NFS4_OP_RENEW,					"RENEW"	},
>  	{	NFS4_OP_RESTOREFH,				"RESTOREFH"	},
>  	{	NFS4_OP_SAVEFH,					"SAVEFH"	},
> -	{	NFS4_OP_SECINFO,					"SECINFO"	},
> -	{	NFS4_OP_SETATTR,					"SETATTR"	},
> -	{	NFS4_OP_SETCLIENTID,				"SETCLIENTID"	},
> +	{	NFS4_OP_SECINFO,				"SECINFO"	},
> +	{	NFS4_OP_SETATTR,				"SETATTR"	},
> +	{	NFS4_OP_SETCLIENTID,			"SETCLIENTID"	},
>  	{	NFS4_OP_SETCLIENTID_CONFIRM,	"SETCLIENTID_CONFIRM"	},
>  	{	NFS4_OP_VERIFY,					"VERIFY"	},
> -	{	NFS4_OP_WRITE,						"WRITE"	},
> +	{	NFS4_OP_WRITE,					"WRITE"	},
>  	{	NFS4_OP_RELEASE_LOCKOWNER,		"RELEASE_LOCKOWNER"	},
> -	{	NFS4_OP_EXCHANGE_ID,		"EXCHANGE_ID" },
> -	{	NFS4_OP_CREATE_SESSION,		"CREATE_SESSION" },
> -	{	NFS4_OP_DESTROY_SESSION,	"DESTROY_SESSION" },
> -	{	NFS4_OP_SEQUENCE,		"SEQUENCE" },
> -	{	NFS4_OP_GETDEVINFO,		"GETDEVINFO"},
> -	{	NFS4_OP_GETDEVLIST,		"GETDEVLIST"},
> -	{	NFS4_OP_LAYOUTCOMMIT,		"LAYOUTCOMMIT" },
> -	{	NFS4_OP_LAYOUTGET,		"LAYOUTGET" },
> -	{	NFS4_OP_LAYOUTRETURN,		"LAYOUTRETURN" },
> -	{	NFS4_OP_NOTIFYDS,		"PNFS_NOTIFYDS"},
> -	{	NFS4_OP_PNFS_CREATE,		"PNFS_CREATE"},
> -	{	NFS4_OP_PNFS_WRITE,		"PNFS_WRITE"},
> -	{	NFS4_OP_PNFS_READ,		"PNFS_READ"},
> -	{	NFS4_OP_ILLEGAL,		"ILLEGAL"},
> +	{	NFS4_OP_BACKCHANNEL_CTL,		"BACKCHANNEL_CTL" },
> +	{	NFS4_OP_BIND_CONN_TO_SESSION,	"BIND_CONN_TO_SESSION" },
> +	{	NFS4_OP_EXCHANGE_ID,			"EXCHANGE_ID" },
> +	{	NFS4_OP_CREATE_SESSION,			"CREATE_SESSION" },
> +	{	NFS4_OP_DESTROY_SESSION,		"DESTROY_SESSION" },
> +	{	NFS4_OP_FREE_STATEID,			"FREE_STATEID"},
> +	{	NFS4_OP_GET_DIR_DELEGATION,		"GET_DIR_DELEGATION"},
> +	{	NFS4_OP_GETDEVINFO,				"GETDEVINFO"},
> +	{	NFS4_OP_GETDEVLIST,				"GETDEVLIST"},
> +	{	NFS4_OP_LAYOUTCOMMIT,			"LAYOUTCOMMIT" },
> +	{	NFS4_OP_LAYOUTGET,				"LAYOUTGET" },
> +	{	NFS4_OP_LAYOUTRETURN,			"LAYOUTRETURN" },
> +	{	NFS4_OP_SECINFO_NO_NAME,		"SECINFO_NO_NAME" },
> +	{	NFS4_OP_SEQUENCE,				"SEQUENCE" },
> +	{	NFS4_OP_SET_SSV,				"SET-SSV"},
> +	{	NFS4_OP_TEST_STATEID,			"TEST-STATEID"},
> +	{	NFS4_OP_WANT_DELEGATION,		"WANT-DELEG" },
> +	{	NFS4_OP_DESTROY_CLIENTID,		"DESTROY-CLIENTID" },
> +	{	NFS4_OP_RECLAIM_COMPLETE,		"RECLAIM-COMPLETE" },
> +	/* Linux NFS 4.1 protocol hackery */

Again, I'm just sorta curious what these extra ops are for.

Also, in the above, well, it's not a huge deal, but--if all the
reformatting was separate from the substantive changes, it'd be easier
to see what was being added.

--b.

> +	{	NFS4_OP_NOTIFYDS,				"PNFS_NOTIFYDS"},
> +	{	NFS4_OP_PNFS_CREATE,			"PNFS_CREATE"},
> +	{	NFS4_OP_PNFS_WRITE,				"PNFS_WRITE"},
> +	{	NFS4_OP_PNFS_READ,				"PNFS_READ"},
> +	{	NFS4_OP_ILLEGAL,				"ILLEGAL"},
>  	{	0,	NULL }
>  };