[pnfs] wireshark

[Tigran Mkrtchyan]

this OPS was defined prior we (Robert and my self) stared to patch.

Tigran.


Benny Halevy wrote:
> On Jun. 03, 2008, 23:01 +0300, "J. Bruce Fields" <bfields at fieldses.org> wrote:
>   
>> On Mon, May 26, 2008 at 09:13:20AM +0200, Tigran Mkrtchyan wrote:
>>     
>>> +/* Not part of the IEFT draft specification */
>>> +#define NFS4_OP_NOTIFYDS              60
>>> +#define NFS4_OP_PNFS_CREATE           61
>>> +#define NFS4_OP_PNFS_WRITE            62
>>> +#define NFS4_OP_PNFS_READ             63
>>>       
>> So what are these last four definitions for?
>>     
>
> Good question.  Doesn't seem like anything we have on linux
> We have an internal op for PNFS_WRITE (to DS), but it
> shouldn't be sent on the wire.  My guess is that this is
> part of the Solaris specific back-end protocol...
> Robert, can you please comment on that?
>
> Benny
>
>   
>>> @@ -138,7 +151,7 @@ extern int dissect_fhandle(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_
>>>  extern int dissect_nfs_fh3(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree,
>>>      const char *name, guint32 *hash);
>>>  
>>> -int dissect_nfs_post_op_attr(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree, 
>>> +int dissect_nfs_post_op_attr(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree,
>>>  		const char* name);
>>>  
>>>  void nfs_name_snoop_add_name(int xid, tvbuff_t *tvb, int name_offset, int name_len, int parent_offset, int parent_len, unsigned char *name);
>>> @@ -155,7 +168,7 @@ void dissect_fhandle_hidden(packet_info *pinfo, proto_tree *tree, int frame);
>>>  typedef int (diss_p)(tvbuff_t *tvb, int offset, proto_tree *tree, int hf);
>>>  
>>>  /* Used in packet-nfsacl.c for NFS_ACL dissection */
>>> -extern int dissect_fattr(tvbuff_t *tvb, int offset, proto_tree *tree, 
>>> +extern int dissect_fattr(tvbuff_t *tvb, int offset, proto_tree *tree,
>>>  	const char* name);
>>>  
>>>  extern int dissect_access(tvbuff_t *tvb, int offset, proto_tree *tree,
>>> @@ -165,4 +178,3 @@ extern gint default_nfs_fhandle_type;
>>>  extern gint hf_nfs_nfsstat;
>>>  
>>>  #endif /* packet-nfs.h */
>>>       
>> I think you meant these last two chunks to go into the second patch?
>>
>> --b.
>> _______________________________________________
>> pNFS mailing list
>> pNFS at linux-nfs.org
>> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>>