[pnfs] [PATCH 1/7] pnfs: BUG: spinlock held during call to setup_layoutcommit

[Benny Halevy]

Merged onto the pnfs branch

Thanks!

Benny

On Jun. 09, 2008, 23:29 +0300, Fred Isaman <iisaman at citi.umich.edu> wrote:
> This just comments the bug.
> 
> Signed-off-by: Fred Isaman <iisaman at citi.umich.edu>
> ---
>  fs/nfs/pnfs.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index afb3d71..f910033 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1894,6 +1894,9 @@ pnfs_layoutcommit_setup(struct pnfs_layoutcommit_data *data, int sync)
>  	 * TODO: We may want to avoid memory copies by delay this
>  	 * until xdr time.
>  	 */
> +	/* BUG - a major purpose of this call is to set (and thus allocate)
> +	 * data->args.new_layout, but pnfs_spinlock is currently held
> +	 */
>  	if (nfss->pnfs_curr_ld->ld_io_ops->setup_layoutcommit) {
>  		result = nfss->pnfs_curr_ld->ld_io_ops->setup_layoutcommit(
>  				nfsi->current_layout,