[pnfs] [PATCH 10/13] ecode/display all delegation flags

[Benny Halevy]

> Subject: [PATCH 10/13] ecode/display all delegation flags
                         ^^^^^
                        decode

> @@ -6910,16 +6926,23 @@ dissect_nfs_open_claim_delegate_cur4(tvbuff_t *tvb, int offset,
>  #define CLAIM_NULL				0
>  #define CLAIM_PREVIOUS			1
>  #define CLAIM_DELEGATE_CUR		2
> -#define CLAIM_DELEGATE_PREV	3
> +#define CLAIM_DELEGATE_PREV		3
> +#define CLAIM_FH				4

leaked one extra tab? :)

> +#define CLAIM_DELEG_CUR_FH		5
> +#define CLAIM_DELEG_CUR_PREV_FH	6
>  
>  static const value_string names_claim_type4[] = {
>  	{	CLAIM_NULL,  		"CLAIM_NULL"  },
>  	{	CLAIM_PREVIOUS, 	"CLAIM_PREVIOUS" },
> -	{	CLAIM_DELEGATE_CUR, 	"CLAIM_DELEGATE_CUR" },
> -	{	CLAIM_DELEGATE_PREV,	"CLAIM_DELEGATE_PREV" },
> +	{	CLAIM_DELEGATE_CUR,	"CLAIM_DELEGATE_CUR" },
> +	{	CLAIM_DELEGATE_PREV,"CLAIM_DELEGATE_PREV" },
> +	{	CLAIM_FH,			"CLAIM_FH" },

What's the point of fixing alignment in one place and
misaligning new code right after that?

Let me guess, your editor is set up to expand tabs to
4 (or some other value != 8) spaces?

BTW, doc/README.developer explicitly says:
1.1.5 White space convention.

Avoid using tab expansions different from 8 column widths, as not all
text editors in use by the developers support this.

> +	{	CLAIM_DELEG_CUR_FH,	"CLAIM_DELEG_CUR_FH"},
> +	{	CLAIM_DELEG_CUR_PREV_FH, "CLAIN_DELEG_CUR_PREV_FH"},
>  	{	0, NULL }
>  };
>  
> +

No need for this extra new line...

Benny

>  static int
>  dissect_nfs_open_claim4(tvbuff_t *tvb, int offset,
>  	proto_tree *tree)