[pnfs] yet another attempt for wireshark patches

J. Bruce Fields bfields at fieldses.org
Fri Jun 20 18:17:17 EDT 2008


On Thu, Jun 19, 2008 at 10:32:33PM +0200, Tigran Mkrtchyan wrote:
> >From 2d25903b4b9490a0dd29760b064c60c3990d8ad0 Mon Sep 17 00:00:00 2001
> From: Tigran Mkrtchyan <tigran.mkrtchyan at desy.de>
> Date: Thu, 19 Jun 2008 21:40:19 +0200
> Subject: [wireshark 06/12] added nfsv4.1 specific etts
> 
> ---
>  epan/dissectors/packet-nfs.c |   24 +++++++++++-------------
>  1 files changed, 11 insertions(+), 13 deletions(-)
> 
> diff --git a/epan/dissectors/packet-nfs.c b/epan/dissectors/packet-nfs.c
> index 042ba4d..ee5780c 100644
> --- a/epan/dissectors/packet-nfs.c
> +++ b/epan/dissectors/packet-nfs.c
> @@ -7198,28 +7198,26 @@ gint *nfsv4_operation_ett[] =
>  	 &ett_nfs_verify4 ,
>  	 &ett_nfs_write4,
>  	 &ett_nfs_release_lockowner4,
> -	 NULL,
> -	 NULL,
> +	 NULL, /* backchannel_ctl */
> +	 NULL, /* bind connection to session */
>  	 &ett_nfs_exchange_id4,
>  	 &ett_nfs_create_session4,
>  	 &ett_nfs_destroy_session4,
> -	 NULL,
> -	 NULL,
> +	 NULL, /* free stateid */
> +	 NULL, /* get dir delegation */
>  	 &ett_nfs_getdevinfo4,
>  	 &ett_nfs_getdevlist4,
>  	 &ett_nfs_layoutcommit4,
>  	 &ett_nfs_layoutget4,
>  	 &ett_nfs_layoutreturn4,
> -	 NULL,
> +	 NULL, /* secinfo no name */
>  	 &ett_nfs_sequence4,
> -	 NULL,
> -	 NULL,
> -	 NULL,
> -	 NULL,
> -	 NULL,
> -	 NULL,
> -	 &ett_nfs_notifyds4,
> -	 &ett_nfs_pnfs_create4
> +	 NULL, /* set ssv */
> +	 NULL, /* test stateid */
> +	 NULL, /* want delegation */
> +	 NULL, /* destroy clientid */
> +	 NULL, /* reclaim complete*/
> +	 NULL /* bogus pad to get to 60*/

I can't figure out why we'd need that final null (and the 60 number
isn't right anymore anyway), so I removed it.

--b.


More information about the pNFS mailing list