[pnfs] yet another attempt for wireshark patches

Halevy, Benny bhalevy at panasas.com
Sat Jun 21 02:47:48 EDT 2008


On Sat 2008-06-21 01:29,  J. Bruce Fields <bfields at fieldses.org> wrote:
> On Thu, Jun 19, 2008 at 10:32:33PM +0200, Tigran Mkrtchyan wrote:
> >
> >
> > I hope this time it's ok
> 
> I fixed up the things I mentioned and pushed the result to
> 
> 	git://linux-nfs.org/~bfields/wireshark.git master
> 
> I compiled the result and ran it with the one simple 4.1 trace I have.
> If anyone else could test it, that'd be great.
> 
> I think the one unaddressed comment is the incomplete attribute
> decoding.  As Benny says, this means that we'll misparse packets with
> the unknown attributes, so this is annoying.  But I guess we should
> submit this as is and add the additional attribute parsing later.
> 
> --b.
> 

Agreed.

Benny


More information about the pNFS mailing list