[pnfs] wireshark patch to decode fattr4_fs_layout_types

J. Bruce Fields bfields at fieldses.org
Mon Jun 23 15:09:45 EDT 2008


On Mon, Jun 23, 2008 at 10:22:01AM +0200, Tigran Mkrtchyan wrote:
>
>
>
> I am not very good in reading hex dumps.
> Patch to show supported layout types by the file system (getattr on  
> mount ) attached.

Thanks, applied to the git tree:

	git://linux-nfs.org/~bfields/wireshark.git master

>  static const value_string names_fattr4[] = {
>  #define FATTR4_SUPPORTED_ATTRS     0
>  	{	FATTR4_SUPPORTED_ATTRS,	"FATTR4_SUPPORTED_ATTRS"	},
> @@ -6846,6 +6861,10 @@ dissect_nfs_attributes(tvbuff_t *tvb, int offset, packet_info *pinfo,
>  						attr_vals_offset = dissect_rpc_uint64(tvb, attr_newftree, 
>  							hf_nfs_fattr4_mounted_on_fileid, attr_vals_offset);
>  						break;
> +					case FATTR4_FS_LAYOUT_TYPE:
> +						attr_vals_offset = dissect_nfs_fs_layout_type(tvb, attr_newftree,
> +													attr_vals_offset);
> +						break;
>  					case FATTR4_LAYOUT_BLKSIZE:
>  						attr_vals_offset = dissect_rpc_uint32(tvb, attr_newftree,
>  							hf_nfs_fattr4_layout_blksize, attr_vals_offset);

My terminal's running out of columns....

Someday when somebody's feeling bored maybe they could move some of
dissect_nfs_attributes into a separate function.

--b.


More information about the pNFS mailing list