[pnfs] [PATCH 1/6] nfs41: save ptr to nfs4_procedures in struct nfs_client

Benny Halevy bhalevy at panasas.com
Tue Jun 24 10:26:18 EDT 2008


Hi Trond, thanks for reviewing and commenting!

Trond Myklebust wrote:
> On Tue, 2008-06-24 at 16:51 +0300, Benny Halevy wrote:
>> To support heterogenuous mount minor version, save ptr to nfs4_procedures
>> in struct nfs_client, use this tabel rather than a global one to get to
>> the actual rpc procedure from the proc level procedure.
>>
> 
> Growl! The rpc_procinfo should already be available from the struct
> rpc_clnt. Adding a second pointer inside the nfs_client is just going to
> be confusing and obfuscating...

Yup. That makes a lot of sense.
Should work smoothly post patch #3 in this series.
I'll rework the patchset accordingly...

Benny

> 
> Trond
> 
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs



More information about the pNFS mailing list