[pnfs] small wireshark patch to update layouttype_names
J. Bruce Fields
bfields at fieldses.org
Wed Jun 25 13:03:21 EDT 2008
On Wed, Jun 25, 2008 at 10:12:56AM -0400, Fredric Isaman wrote:
>
>
> On Tue, 24 Jun 2008, J. Bruce Fields wrote:
>
>> On Tue, Jun 24, 2008 at 03:55:44PM +0200, Thijs Stuurman wrote:
>>> I noticed wireshark used different names then those used in draft version 23.
>>>
>>> --- packet-nfs.c 2008-06-23 10:42:38.000000000 +0200
>>> +++ packet-nfs.c 2008-06-24 15:42:46.000000000 +0200
>>> @@ -8990,9 +8990,9 @@
>>> };
>>>
>>> static const value_string layouttype_names[] = {
>>> - { 1, "LAYOUT_NFSV4_FILES"},
>>> - { 2, "LAYOUT_OSD2_OBJECTS"},
>>> - { 3, "LAYOUT_BLOCK_VOLUME"},
>>> + { 1, "LAYOUT4_NFSV4_1_FILES"},
>>> + { 2, "LAYOUT4_OSD2_OBJECTS"},
>>> + { 3, "LAYOUT4_BLOCK_VOLUME"},
>>> { 0, NULL }
>>> };
>>
>> These are for humans to read, so we don't actually need the full names
>> from the spec. Maybe just dropping the LAYOUT4_ and using the rest
>> would be simplest. Any preferences?
>>
>
> I generally prefer using the XDR names from the spec, as it makes it easy
> to search for the appropriate code in the *.x file.
OK, OK, I'll cave. Applied by hand and pushed out.
--b.
More information about the pNFS
mailing list