[pnfs] [PATCH 12/28] pnfs: BUG: spinlock is held while calling alloc_lseg

Fred Isaman iisaman at citi.umich.edu
Tue Mar 11 15:31:53 EDT 2008


From: Fred <iisaman at citi.umich.edu>

FIXME - this is just a reminder that the bug exists.

Signed-off-by: Fred <iisaman at citi.umich.edu>
---
 fs/nfs/pnfs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 7a7379d..56aa1bf 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -665,6 +665,7 @@ pnfs_inject_layout(struct pnfs_layout_type *lo,
 	struct pnfs_layout_segment *lseg;
 
 	dprintk("%s Begin\n", __FUNCTION__);
+	/* FIXME - BUG - this is called while holding nfsi->lo_lock spinlock */
 	lseg = PNFS_LD_IO_OPS(lo)->alloc_lseg(lo, lgr);
 	if (!lseg || IS_ERR(lseg)) {
 		if (!lseg)
-- 
1.5.3.3



More information about the pNFS mailing list