[pnfs] max_resp_sz_cached

Benny Halevy bhalevy at panasas.com
Thu Mar 13 12:11:32 EDT 2008


Ricardo, I think you wrote this originally...

in nfs4_adjust_channel_attrs, we do the following:

	if (req_attrs->max_resp_sz < resp_attrs->max_resp_sz)
		resp_attrs->max_resp_sz = req_attrs->max_resp_sz;

	if (req_attrs->max_resp_sz_cached < resp_attrs->max_resp_sz)
		resp_attrs->max_resp_sz = req_attrs->max_resp_sz_cached;

note that in the second statement we adjust resp_attrs->max_resp_sz
rather than resp_attrs->max_resp_sz_cached.

I wonder is this intentional (or a bug :)?
If done on purpose, what is the reason for doing that,
and can you provide a patch with a suitable comment?

Thanks,

Benny




More information about the pNFS mailing list