[pnfs] [PATCH 3/4] nfs41: no need to rpc_wake_up_task innfs4_find_slot

[Benny Halevy]

Hi Rahul,  I didn't release the resent patchsets I sent for review yet.
You can view how the apply here:
http://www.bhalevy.com/git/gitweb.cgi?p=linux-pnfs.git;a=tree

Benny

On Mar. 15, 2008, 3:17 +0200, "Iyer, Rahul" <Rahul.Iyer at netapp.com> wrote:
> Hi Benny,
> Is there a gitweb setup where I can view the current codebase? I'd like
> to see the code this patch applies to and I'm afraid I haven't been
> entirely up to date.
> -Rahul
>  
> 
> -----Original Message-----
> From: Benny Halevy [mailto:bhalevy at panasas.com] 
> Sent: Friday, March 14, 2008 4:13 AM
> To: pnfs at linux-nfs.org
> Subject: [pnfs] [PATCH 3/4] nfs41: no need to rpc_wake_up_task
> innfs4_find_slot
> 
> First, why wake up task when the slot is allocated.  If at all, waking
> up should take plase when freeing a slot and there are one or more tasks
> waiting for it.
> 
> Second, this seems to cause in infinite loop in the rpc stae machine
> over the 2.6.25 codebase.
> 
> Signed-off-by: Benny Halevy <bhalevy at panasas.com>
> ---
>  fs/nfs/nfs4proc.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index
> 8b1bf5d..0203afe 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -326,9 +326,6 @@ static struct nfs4_slot *nfs4_find_slot(struct
> nfs4_slot_table *tbl,
>  	slot = __nfs4_find_slot(tbl);
>  	spin_unlock(&tbl->slot_tbl_lock);
>  
> -	if (slot)
> -		rpc_wake_up_task(task);
> -
>  	return slot;
>  }
>  
> --
> 1.5.3.3
> 
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs