[pnfs] [PATCH 04/10] [nfs41-2.6.25] nfs41: no need to rpc_wake_up_task in nfs4_find_slot
Benny Halevy
bhalevy at panasas.com
Thu Mar 20 12:21:59 EDT 2008
First, why wake up task when the slot is allocated. If at all,
waking up should take plase when freeing a slot and there are one
or more tasks waiting for it.
Second, this seems to cause in infinite loop in the rpc stae machine
over the 2.6.25 codebase.
Signed-off-by: Benny Halevy <bhalevy at panasas.com>
---
fs/nfs/nfs4proc.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 6eb5455..1c93a25 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -326,9 +326,6 @@ static struct nfs4_slot *nfs4_find_slot(struct nfs4_slot_table *tbl,
slot = __nfs4_find_slot(tbl);
spin_unlock(&tbl->slot_tbl_lock);
- if (slot)
- rpc_wake_up_task(task);
-
return slot;
}
--
1.5.3.3
More information about the pNFS
mailing list