[pnfs] [PATCH 3/4] nfsd41: SUPPATTR_EXCLCREAT attribute

[J. Bruce Fields]

On Mon, May 12, 2008 at 07:39:05PM -0700, Benny Halevy wrote:
> Sorry about the noise but please ignore my previous reply since
> I've found a few more places that need minorversion attention.

Thanks, yeah, I was about to comment that adding an extra argument to
all these functions was a little cumbersome and that maybe we should add
it to the rqst or the cstate.

> Here's the latest version (might change further while I'm testing it...)
> 
> For performance reasons I tried to stick to macros and static inline
> functions rather than using global arrays to keep the per-minorversion
> word masks.  What do you think?

That seems likely to be lost in the noise--I'd rather you choose
whatever you think will look most obvious to the reader.  (Which may be
this, I don't know.)

> @@ -1755,7 +1758,7 @@ static __be32 fattr_handle_absent_fs(u32 *bmval0, u32 *bmval1, u32 *rdattr_err)
>  __be32
>  nfsd4_encode_fattr(struct svc_fh *fhp, struct svc_export *exp,
>  		struct dentry *dentry, __be32 *buffer, int *countp, u32 *bmval,
> -		struct svc_rqst *rqstp, int ignore_crossmnt)
> +		struct svc_rqst *rqstp, int ignore_crossmnt, u32 minorversion)

That argument list is already a little cumbersome; maybe just pass the
cstate?

--b.