[pnfs] [0.5/20]: Fixes, fixes, fixes....

[Dean Hildebrand]

William A. (Andy) Adamson wrote:
> Hi Dean
>
> We should be removing dprintk's, not adding them. You have added a
> bunch of dprintk's that are OK for debugging, but should not be part
> of the submitted code. We will need to remove most dprintk's prior to
> submission to Trond and Bruce.
>
> For example, printing the reference count in a get/put routine,
> printing in the body of list traversal or adding a count for debugging
> and then printing it, etc.
>
> Could you please re-submit without the dprintk's.
>   
I agree for the submitted code, but the code is not stable, and the more 
debugging info the better.  Once the pnfs code is ready for submission, 
we should go through the code and remove/add debugging/comments as 
necessary.
Dean
> -->Andy
>
> On Mon, Oct 13, 2008 at 11:44 PM, Dean Hildebrand <seattleplus at gmail.com> wrote:
>   
>> Here are the patches again, hopefully addressing Benny's
>> comments.  I replaced patch 20 with a new patch that simply
>> cleans up the stateids on the DS on nfsd exit.  This is needed
>> no matter how we resolve this outstanding issue.  Hopefully we
>> can talk about it on Thursday.
>>
>> Dean
>> _______________________________________________
>> pNFS mailing list
>> pNFS at linux-nfs.org
>> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>>
>>