[pnfs] [PATCH 0/35] pnfsd-files

[Benny Halevy]

On Oct. 22, 2009, 2:20 +0200, Christoph Hellwig <hch at infradead.org> wrote:
> Just glanced at a few random patches and it's pretty obvious that you
> need to re-evaluate your stances about ifdefs in these patches.
> 
> Whenever possible conditional code should be in separate files that are
> conditionally compiled instead of having ifdefs all over the code,

I agree.  Boaz started moving some of that, see:
http://linux-nfs.org/pipermail/pnfs/2009-October/009472.html
fs/nfsd/nfs4pnfsd.c, for example, is conditionally compiled
for CONFIG_PNFSD

> including around the whole contents of files.  Also in headers
> conditionally used defintiones don't need ifdefs, only code that
> actually is different for !CONFIG_PNFSD, e.g. stubs for calls.
> 

Yup.

Thanks for reviewing!

Benny